Add execution options for processor and prover #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fumuran
force-pushed
the
andrew-processor-exec-options
branch
3 times, most recently
from
c4e50f0
to
bac3fb1
Compare
tohrnii
approved these changes
Jul 7, 2023
bobbinth
requested changes
Jul 8, 2023
Fumuran
force-pushed
the
andrew-processor-exec-options
branch
4 times, most recently
from
7a57b4f
to
e410488
Compare
Fumuran
force-pushed
the
andrew-processor-exec-options
branch
from
e410488
to
cc03814
Compare
Fumuran
force-pushed
the
andrew-processor-exec-options
branch
from
cc03814
to
e7f1044
Compare
bobbinth
requested changes
Jul 18, 2023
bobbinth
approved these changes
Jul 18, 2023
air/src/options.rs
Outdated
Comment on lines
92
to
94
| /// Sets [ExecutionOptions] for this [ProvingOptions]. | ||
| /// This sets the maximum number of cycles a program is allowed to execute as well as |
There was a problem hiding this comment.
nit: we should add a blank line between the intro sentence and the rest of the comment. Otherwise, doc formatter will not format them well.
Fumuran
force-pushed
the
andrew-processor-exec-options
branch
from
ff6d0dd
to
2dca4b9
Compare
Fumuran
force-pushed
the
andrew-processor-exec-options
branch
from
2dca4b9
to
c61da48
Compare
This was referenced Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds implementation and usage for the
ExecutionOptionsstruct, used to limit the maximum number of cycles and set their estimated number. CLI was changed to parse new parameters for theExecutionOptions.This is the preparatory PR, that is data in this struct is not used anywhere yet. The actual limitations will be implemented in the next PR.